Splice-out Regression and Restart Fixes #6677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddustin
force-pushed
the
ddustin/splice_out_test
branch
8 times, most recently
from
853e299
to
d4f90f6
Compare
ddustin
changed the title
ddustin
force-pushed
the
ddustin/splice_out_test
branch
4 times, most recently
from
30d534f
to
5fa1e16
Compare
This was referenced Sep 19, 2023
ddustin
force-pushed
the
ddustin/splice_out_test
branch
2 times, most recently
from
dbe0e15
to
64a26df
Compare
|
OK, you need to split the "fix" commit off from the "add test" commit. If we do another point release, we'll include the fix commit, but not the test one... |
ddustin
force-pushed
the
ddustin/splice_out_test
branch
2 times, most recently
from
b838308
to
0530ffb
Compare
3 tasks
ddustin
force-pushed
the
ddustin/splice_out_test
branch
from
0530ffb
to
54dbc5c
Compare
Moved the tests out and put them in #6676 for now |
Added a test for splicing out that exposed some behavior and code glitches that are addressed in this commit. Added test for splice gossip. Also added documentation for how to do a splice out. ChangeLog-Fixed: Added docs, testing, and some fixes related to splicing out, insufficent balance handling, and restarting during a splice.
ddustin
force-pushed
the
ddustin/splice_out_test
branch
from
54dbc5c
to
39da2f4
Compare
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran a test for splicing out that exposed some behavior and code glitches that are addressed in this PR.
Added test for splice gossip.
Also added documentation for how to do a splice out.
Fixes #6658
Fixes #6656
Fixes #6613
Fixes #6612
Fixes #6572
Fixes #6481