Plugin crash fixes! #6570
Merged
Plugin crash fixes! #6570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
approved these changes
Aug 16, 2023
| @@ -0,0 +1,15 @@ | |||
| #!/some/bad/path/to/python3 | |||
There was a problem hiding this comment.
ah yes, classic user error here
|
Fixed up missing commit message... |
rustyrussell
force-pushed
the
guilt/plugin-crash-go-away
branch
from
764a64c to
31c1694
Compare
…plugin startdir` It hits the new assert(): before that (tested!) it actually kills everything and logs you out. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/plugin-crash-go-away
branch
from
31c1694 to
815af46
Compare
…es not put it in plugins list. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/plugin-crash-go-away
branch
from
815af46 to
05aabe9
Compare
Reported-by: @niftynei Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Plugins: we clean up properly if a plugin fails to start, and we don't kill all processes if it's from `plugin startdir`.
rustyrussell
force-pushed
the
guilt/plugin-crash-go-away
branch
from
05aabe9 to
538492b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It started with "plugin still in listplugins after it fails to exec" and escalated to "we can kill all our processes"!