Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove Sync requirements on Futures returned in the Rust plugin library. #6490

Merged
merged 1 commit into from
Aug 8, 2023

Commits on Aug 3, 2023

  1. Fix: Remove Sync requirements on Futures returned in the Rust plugin …

    …library.
    
    See: bitcoindevkit/bdk#1047 (comment)
    
    In general, futures produced by most libraries in the ecosystem of Rust, and bounds placed
    on users of famous runtimes like tokio and its spawn method all lack Sync requirements.
    
    Because of this, anyone who creates a callback using any sort of library that returns a
    non-Sync future (which most libraries fit this description) inside of it will get some
    cryptic error messages (async error messages still leave a lot to be desired).
    
    Removing these Sync requirements will make the library more useful.
    junderw committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d163230 View commit details
    Browse the repository at this point in the history