msggen: Add two missing fields to the listpays schema
#6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
20230725-listpayspays-missing-amount
branch
2 times, most recently
from
89659dd
to
1f477c9
Compare
rustyrussell
approved these changes
Jul 25, 2023
cdecker
force-pushed
the
20230725-listpayspays-missing-amount
branch
5 times, most recently
from
734934e
to
d9fbb94
Compare
The fields were missing because they weren't annotated with a type and a description. Adding those fixes them. Changelog-Fixed: msggen: `listpays` now includes the missing `amount_msat` and `amount_sent_msat` fields No-schema-diff-check: fields were always there, just undocumented!
rustyrussell
force-pushed
the
20230725-listpayspays-missing-amount
branch
from
d9fbb94
to
d55fd50
Compare
|
Ack d55fd50 (Used No-schema-diff-check magic instead of disabling in Makefile) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields were missing because they weren't annotated with a type and a description. Adding those fixes them.
Changelog-Fixed: msggen:
listpaysnow includes the missingamount_msatandamount_sent_msatfields