Self-pay support. #6399
Merged
Self-pay support. #6399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/selfpay
branch
from
9afcb79
to
47cff52
Compare
rustyrussell
force-pushed
the
guilt/selfpay
branch
2 times, most recently
from
34179d3
to
e8954cb
Compare
cdecker
reviewed
Jul 20, 2023
We want to allow this, so write a test. Signed-off-by: Rusty Russell <[email protected]>
… sat/msat. Signed-off-by: Rusty Russell <[email protected]>
It's not that uncommon to want to pass NULL through, for optional strings. Signed-off-by: Rusty Russell <[email protected]>
… on null columns The other _arr helpers allow this, and we want it for the next patch. Signed-off-by: Rusty Russell <[email protected]>
We'll need to do this for self-pay as well. Signed-off-by: Rusty Russell <[email protected]>
We open-coded initialization in two places, now we will want a third, it's time to clean up. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/selfpay
branch
from
e8954cb
to
0b222e9
Compare
Clean these up: they were debug logs, but we want to pass this information back for self-payments. Also fixes "Attept" typo which altered tests! Signed-off-by: Rusty Russell <[email protected]>
We'll want this without an htlc_out, for self-pay. Signed-off-by: Rusty Russell <[email protected]>
Previously, the "payment" and "invoice" paths were completely separate, but this now calls both. It bypasses htlc_sets (and thus, cannot do MPP), and bypasses the hook too: the former is tied closely to HTLCs, and the hook is also very htlc-centric. Includes finishing unfinished sentence in sendpay man page, as a bonus. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Plugins: `sendpay` now allows self-payment of invoices, by specifying an empty route.
This is the simplest solution, not the best, but there's significant risk in try to remove the "we have a path" assumption in the code pay code. Includes removing a `tal_steal` which was incorrect: the buffer has the same lifetime as the plugin, so if we steal it then things get messy when we free the struct payment. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Plugins: `pay` will now pay your own invoices if you try.
rustyrussell
force-pushed
the
guilt/selfpay
branch
from
0b222e9
to
f7a3d1d
Compare
Comment on lines
386
to
392
| if (invoices_find_by_rhash(ld->wallet->invoices, &inv_dbid, payment_hash)) { | ||
| log_debug(ld->log, "ALREADY paid invoice %s", | ||
| type_to_string(tmpctx, struct sha256, payment_hash)); | ||
| *err = tal_fmt(ctx, "Already paid or expired invoice %s", | ||
| type_to_string(tmpctx, struct sha256, payment_hash)); | ||
| } else { | ||
| *err = tal_fmt(ctx, "Unknown invoice %s", | ||
| type_to_string(tmpctx, struct sha256, payment_hash)); | ||
| } |
There was a problem hiding this comment.
we can write the if without {...} here just to be consistent with the our code
There was a problem hiding this comment.
No, if there is multiline code I prefer {} for clarity. It's fine to omit for simple cases, ofc.
cdecker
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular request. The sendpay infrastructure isn't too bad, but the path to put it into the pay plugin is (perhaps) oversimplified. Still, it's designed not to break normal payments in any way.