wallet: don't try to set a timer past 2038 on 32-bit platforms. #6361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'll wrap, probably be in the past, and infinite loop. This was caused by an invoice with expiry set at 2076. This wrap caused us to think the expiry has already passed, and keep looping! Reported-by: @telelvis Fixes: ElementsProject#6339 Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: lightnind: don't infinite loop on 32 bit platforms if only invoices are expiring after 2038.
|
ACK d61706f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'll wrap, probably be in the past, and infinite loop. This was caused by an invoice with expiry set at 2076. This wrap caused us to think the expiry has already passed, and keep looping!
Reported-by: @telelvis
Fixes: #6339
Changelog-Fixed: lightnind: don't infinite loop on 32 bit platforms if only invoices are expiring after 2038.