pytest: fix test_cln_plugin_reentrant which panics rust under CI. #6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we release too fast, the plugin crashes: ``` thread 'tokio-runtime-worker' panicked at 'called Result::unwrap() on an Err value: SendError(())', plugins/examples/cln-plugin-reentrant.rs:31:27 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace ``` This happens with CI under VALGRIND! Signed-off-by: Rusty Russell <[email protected]>
Without this, a stuck test (such as before the previous commit, where a plugin crashed when running a command) simply gets timed out by the full CI timeout. Signed-off-by: Rusty Russell <[email protected]>
|
Indeed, I've bumped it up, let's see... |
|
ACK 5b33ff3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was hastily written, plugin crashed, command didn't return, pytest doesn't run with --timeout: CI just killed it after two hours.
Changelog-None