Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clnrs: Add custom conversion for routehints #6154

Merged
merged 2 commits into from
Apr 10, 2023
Merged

clnrs: Add custom conversion for routehints #6154

merged 2 commits into from
Apr 10, 2023

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Apr 6, 2023

We were using two incompatible custom types (dicts vs arrays), so we need a custom conversion.

Reported by @Evanfeenstra
Fixes #6143

@cdecker
Copy link
Member Author

cdecker commented Apr 6, 2023

Notice that we implement only Serialize for now, since the inverse direction from JSON to cln-rpc request is not used, but could eventually be used to re-expose the GRPC interface as a JSON interface, but we don't do that right now, so adding that implementation would be premature.

@cdecker cdecker mentioned this pull request Apr 6, 2023
Closed
@cdecker cdecker added this to the v23.05 milestone Apr 6, 2023
@cdecker cdecker changed the title 20230406 grpc routehint clnrs: Add custom conversion for routehints Apr 6, 2023
vincenzopalazzo
vincenzopalazzo approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b370ea0

@rustyrussell rustyrussell merged commit 6d76642 into ElementsProject:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v23.05
Development

Successfully merging this pull request may close these issues.

Incorrect validation on keysend route hints
3 participants
@cdecker @vincenzopalazzo @rustyrussell