-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blinded payments are no longer experimental (and other BOLT updates along the way) #6138
Merged
rustyrussell
merged 8 commits into
ElementsProject:master
from
rustyrussell:guilt/onionpay-not-experimental
Apr 7, 2023
Merged
Blinded payments are no longer experimental (and other BOLT updates along the way) #6138
rustyrussell
merged 8 commits into
ElementsProject:master
from
rustyrussell:guilt/onionpay-not-experimental
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
changed the title
Blinded payments are not experimental (and other BOLT updates along the way)
Blinded payments are no longer experimental (and other BOLT updates along the way)
Apr 1, 2023
rustyrussell
force-pushed
the
guilt/onionpay-not-experimental
branch
from
April 2, 2023 06:01
a7bb355
to
be623f5
Compare
cdecker
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK be623f5
It's in the main bolt, so remove qualifies from the bolt quote so they are checked. Signed-off-by: Rusty Russell <[email protected]>
Too much context, it didn't apply if you try to rebuild from source! Signed-off-by: Rusty Russell <[email protected]>
"BOLT 4: Remove legacy format, make var_onion_optin compulsory." This also renamed the redundant "tlv_payload" to "payload", so we replace "tlv_tlv_payload" with "tlv_payload" everyhere! Signed-off-by: Rusty Russell <[email protected]>
"Allow nodes to overshoot the MPP `total_msat` when paying (ElementsProject#1031)" Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: Protocol: Allow slight overpaying, even with MPP, as spec now recommends.
"Allow nodes to overshoot final htlc amount and expiry (ElementsProject#1032)" Note that this also renamed `min_final_cltv_expiry` to the more-correct `min_final_cltv_expiry_delta`. Signed-off-by: Rusty Russell <[email protected]>
"BOLT 04: remove associated data from test vector" (We actually use merge point). Signed-off-by: Rusty Russell <[email protected]>
"BOLT 03: fix static-remote same amt and pre-image test vector" Signed-off-by: Rusty Russell <[email protected]>
In particular: - Bolt 4: add route blinding construction - Bolt 4: add blinded payments And this means it's not experimental, so we can turn it on by default! Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: blinded payments are now supported by default (not just with `--experimental-onion-messages`)
rustyrussell
force-pushed
the
guilt/onionpay-not-experimental
branch
from
April 7, 2023 06:57
be623f5
to
c7419fd
Compare
Fixed trivial backwards payment test which caused all payments to fail! Ack c7419fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.