Fix sql nodes table (again) #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As soon as we apply the next commit, we get a new problem: the delete code didn't work. Signed-off-by: Rusty Russell <[email protected]>
Without this patch, we only ever loaded the "nodes" table once, then didn't see updates. How this ever got past CI is a mystery; perhaps valgrind was so slow that the updated node_announcement hit the gossmap before we even asked sql on l3 about the nodes table? Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Plugins: `sql` nodes table now gets refreshed when gossip changes.
I'm guessing it has to do with the default wait_for timeout of 60s (or 180s in the case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't updating, and thus failing locally: perhaps the test is not working properly under valgrind?