topology: fix memleak in listchannels #5865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local_connected allocates a struct node_map off of the struct listchannels_opts but fails to ever release the internal table, so those table allocations hang around forever. Add node_map_clear as a destructor for the struct node_map to ensure that the internal table is freed when the enclosing struct is freed. Changelog-Fixed: topology: Fixed memleak in `listchannels` Signed-off-by: Matt Whitlock <[email protected]>
|
This is correct, good find! I thought I'd changed our hash tables to all use tal, but I had actually not put up a PR for those. I'll apply this, then rebase that on top! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local_connectedallocates astruct node_mapoff of thestruct listchannels_optsbut fails to ever release the internal table, so those table allocations hang around forever. Addnode_map_clearas a destructor for thestruct node_mapto ensure that the internal table is freed when the enclosing struct is freed.