ipdiscovery: adds custom port parameter #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
force-pushed
the
ipdiscovery/port
branch
3 times, most recently
from
0b343a1 to
c95de48
Compare
m-schmoock
force-pushed
the
ipdiscovery/port
branch
from
c95de48 to
8fdd7dd
Compare
m-schmoock
force-pushed
the
ipdiscovery/port
branch
3 times, most recently
from
4547901 to
410b5af
Compare
|
@endothermicdev |
m-schmoock
force-pushed
the
ipdiscovery/port
branch
from
410b5af to
ef929f9
Compare
|
I'm running this and #5841 now on my patched mainnet node. No issues so far |
This will give the user an option to set a custom port when using discovered IPs for node_announcents. Without this, only the selected networks default port can used. Changelog-Added: Adds --announce-addr-discovered-port config option to set custom port for IP discovery.
m-schmoock
force-pushed
the
ipdiscovery/port
branch
from
ef929f9 to
1700d9e
Compare
|
Just a final rebase... |
|
Looking good 👍 ACK 1700d9e |
cdecker
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a config option
--announce-addr-discovered-portthat can set a non default port when using IP discovery onnode_announcementupdates. Currently and without this only the selected networks default port will be used.