Make modern string-based JSON ids opt in, deprecate numeric ones #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <[email protected]>
…` field. And document support for it. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Plugins: `getmanfest` response can contain `nonnumericids` to indicate support for modern string-based JSON request ids. Changelog-Deprecated: Plugins: numeric JSON request ids: modern ones will be strings (see doc/lightningd-rpc.7.md!)
We also remember whether the id is a string or not, for replacement in JSON passthrough. Signed-off-by: Rusty Russell <[email protected]>
…w non-numeric JSON ids. Signed-off-by: Rusty Russell <[email protected]>
cdecker
approved these changes
Nov 21, 2022
| @@ -46,6 +46,7 @@ where | |||
| rpcmethods: HashMap<String, RpcMethod<S>>, | |||
| subscriptions: HashMap<String, Subscription<S>>, | |||
| dynamic: bool, | |||
| nonnumericids: bool, | |||
There was a problem hiding this comment.
The Rust plugin handles the id completely internally, so this is not needed at all (also why the warning is being returned during compilation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not actually as bad as you'd think; we already handle arbitrary ids, it's just that we need to remember if this request id is a string or not. Most of the code is plumbing, to only set the flag when the plugin says we can.
This fixes clboss!
I get a new rust warning, though, suspect my monkey coding there is wrong: