Blinded payments spec update and infrastructure for forwarding #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
the
protocol
rustyrussell
force-pushed
the
blinded-payments-infra
branch
from
ef5a019 to
df9cc4a
Compare
|
ACK df9cc4a |
cdecker
approved these changes
Oct 11, 2022
|
There seems to be a BOLT-quote mismatch somewhere: |
With the rise of external HSMs like VLS, this is no longer an internal-only API. Fortunately, it doesn't change very fast so maintenance should not be a huge burden. Signed-off-by: Rusty Russell <[email protected]>
…ents does Otherwise I know we'll miss it. Simply check for a mention: we could well change things multiple times within a single release. Signed-off-by: Rusty Russell <[email protected]>
We still use 32 bytes on the wire, but internally don't use x-only. Signed-off-by: Rusty Russell <[email protected]>
…ays 02) This is the one place where we hand point32 over the wire internally, so remove it. This is also our first hsm version change! Signed-off-by: Rusty Russell <[email protected]>
It was very tied to x-only keys; we could support it in a backwards compatibility mode for a while, but getting refunds or proving old pre-finalization invoices is not worth spending time on. Changelog-EXPERIMENTAL: offers: old `payer_key` proofs won't work. Signed-off-by: Rusty Russell <[email protected]>
This removes a point32 dependency. Signed-off-by: Rusty Russell <[email protected]>
Most things don't want them, so don't link it into everything by default. Signed-off-by: Rusty Russell <[email protected]>
It's 2b7ad577d7a790b302bd1aa044b22c809c76e49d, which reverts the point32 changes. It also restores send_invoice in `invoice`, which we had removed from spec and put into the recurrence patch. I originally had implemented compatibility, but other changes which followed this are far too widespread. Signed-off-by: Rusty Russell <[email protected]> Changelog-EXPERIMENTAL: offers: complete rework of spec from other teams (yay!) breaks previous compatibility (boo!)
…aths. We need to print out first_node_id, and "node_id" is now called "blinded_node_id" in the spec. And the schema didn't include the payment fields in the blinded path for invoices (which broke as soon as we actually tested one!). Signed-off-by: Rusty Russell <[email protected]>
The x-only dream is dead. Remove all trace. Signed-off-by: Rusty Russell <[email protected]>
This is as of commit aed5518a80aade56218da87f92e0a39963b660cf Signed-off-by: Rusty Russell <[email protected]>
…g test for new vectors. Signed-off-by: Rusty Russell <[email protected]>
It's a premature optimization, and it make modifications more complex. Signed-off-by: Rusty Russell <[email protected]>
|
Yep, fixed: this is actually a quote from the route-blinding branch only. |
We're going to share them for onion messages as well as for blinded payments. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
We don't set it, but we know how to now. Signed-off-by: Rusty Russell <[email protected]>
We make it look like a normal payment for the caller. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Don't shoehorn it into onion_nonfinal_hop() and onion_final_hop(), but provide an explicit routine "blinded_onion_hops" and an onion helper "onion_blinded_hop()" for it to call. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
…RES. Gate it (where necessary) by the route-blinding feature bit. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Mainly, field name changes. Signed-off-by: Rusty Russell <[email protected]> Changelog-EXPERIMENTAL: Protocol: Support for forwarding blinded payments (as per latest draft)
Instead of open coding in connectd/onion_message, we move it to common with a nice API. This lets us process the BOLT test vectors. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
blinded-payments-infra
branch
from
df9cc4a to
1c99717
Compare
|
Trivial rebase on master, those simple typo fixes, and added (as first two commits) a new API system for hsmd_wire.csv |
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
blinded-payments-infra
branch
from
1c99717 to
0152ffe
Compare
And add it as a requirement to the test programs! Signed-off-by: Rusty Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a pile of updates:
This PR does not include: