Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getinfo showing unannounced discovered IPs #5584

Merged
merged 2 commits into from
Sep 11, 2022
Merged

fix: getinfo showing unannounced discovered IPs #5584

merged 2 commits into from
Sep 11, 2022

Conversation

m-schmoock
Copy link
Collaborator

This fixes a visual bug in getinfo output, which contained unannounced
auto discovered IP addresses when announcement of discovered IPs
was actually turned off.

Addresses #5553

@m-schmoock
peer_control: fix getinfo showing unannounced addr
8090f4a 
Currently discovered IPs are only announced when we don't have any
usable addresses detected or configured already. However, the cli
command `getinfo` still showed theses unannounced addr as if they
were announced.

Changelog-Fixed: peer_control: getinfo showing unannounced addresses.
@m-schmoock
cleanup: fix mixed indentation of json_getinfo
c4c89ab 
This one got badly messed up over time. I know we usually don't fix
these to have easier git-bisect. I can remove this commit if required.
@m-schmoock m-schmoock mentioned this pull request Sep 11, 2022
Closed
@m-schmoock
Copy link
Collaborator Author

... I still need to fix getinfo showing outbound ports on discovered addresses instead of chainparams_get_ln_port(chainparams).

cdecker
cdecker approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c4c89ab

@m-schmoock
Copy link
Collaborator Author

@cdecker
Just to confirm, are we okay having indentation cleanup commits like c4c89ab ?

@cdecker
Copy link
Member

cdecker commented Sep 11, 2022

I'm fine with them, as long as they are clearly marked as cleanup, to save on reviewer time (I sometimes spent several minutes on whitespace only commits trying to figure out what the changes are, only to realize there aren't any 😜)

@m-schmoock m-schmoock merged commit c685874 into ElementsProject:master Sep 11, 2022
@m-schmoock m-schmoock deleted the fix/getinfo_ip_discovery branch September 12, 2022 13:49
@niftynei niftynei mentioned this pull request Sep 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdecker cdecker cdecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-schmoock @cdecker