Postgres crash fix #5513
Merged
Postgres crash fix #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It crashes with: ``` s32 field doesn't match size: expected 4, actual 8 ``` Reported-by: @zerofeerouting Signed-off-by: Rusty Russell <[email protected]>
Postgresql actually checks, and fails. It's unclear why this field is an INTEGER (and u32) when it's a BIGINT in db here (it's an INTEGER in the channels table, just a BIGINT in the channel_funding_inflights table). Changelog-Fixed: db: postgresql crash on startup when dual-funding lease open is pending with "s32 field doesn't match size: expected 4, actual 8" Signed-off-by: Rusty Russell <[email protected]>
jb55
reviewed
Aug 10, 2022
| @@ -1133,7 +1134,7 @@ wallet_stmt2inflight(struct wallet *w, struct db_stmt *stmt, | |||
| if (!db_col_is_null(stmt, "lease_commit_sig")) { | |||
| lease_commit_sig = tal(tmpctx, secp256k1_ecdsa_signature); | |||
| db_col_signature(stmt, "lease_commit_sig", lease_commit_sig); | |||
| lease_chan_max_msat = db_col_int(stmt, "lease_chan_max_msat"); | |||
| lease_chan_max_msat = db_col_u64(stmt, "lease_chan_max_msat"); | |||
There was a problem hiding this comment.
ACK, I was wondering how this works on the sqlite site but it looks like sqlite integers are 8 bytes anyways...
|
note: test flake is patched in #5503 |
niftynei
reviewed
Aug 10, 2022
| @pytest.mark.openchannel('v2') | ||
| @pytest.mark.developer("requres 'dev-disconnect'") | ||
| def test_inflight_dbload(node_factory, bitcoind): | ||
| """Bad db field access breaks Postgresql on startup with opening leases""" |
There was a problem hiding this comment.
extremely minor nit: technically it only breaks if you try to load inflights from a postgres db, which happens in the case that a channel open isn't resolved at startup
|
ACK 1da6c40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note new Changelog line!