Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix wrong_funding description in manpage and type in schema #5444

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cln-grpc/proto/node.proto
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ message CloseRequest {
optional uint32 unilateraltimeout = 2;
optional string destination = 3;
optional string fee_negotiation_step = 4;
optional bytes wrong_funding = 5;
optional Outpoint wrong_funding = 5;
optional bool force_lease_closed = 6;
repeated Feerate feerange = 7;
}
Expand Down
2 changes: 1 addition & 1 deletion cln-grpc/src/convert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ impl From<&pb::CloseRequest> for requests::CloseRequest {
unilateraltimeout: c.unilateraltimeout.clone(), // Rule #1 for type u32?
destination: c.destination.clone(), // Rule #1 for type string?
fee_negotiation_step: c.fee_negotiation_step.clone(), // Rule #1 for type string?
wrong_funding: c.wrong_funding.clone().map(|v| hex::encode(v)), // Rule #1 for type txid?
wrong_funding: c.wrong_funding.as_ref().map(|a| a.into()), // Rule #1 for type outpoint?
force_lease_closed: c.force_lease_closed.clone(), // Rule #1 for type boolean?
feerange: Some(c.feerange.iter().map(|s| s.into()).collect()), // Rule #4
}
Expand Down
2 changes: 1 addition & 1 deletion cln-rpc/src/model.rs
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ pub mod requests {
#[serde(alias = "fee_negotiation_step", skip_serializing_if = "Option::is_none")]
pub fee_negotiation_step: Option<String>,
#[serde(alias = "wrong_funding", skip_serializing_if = "Option::is_none")]
pub wrong_funding: Option<String>,
pub wrong_funding: Option<Outpoint>,
#[serde(alias = "force_lease_closed", skip_serializing_if = "Option::is_none")]
pub force_lease_closed: Option<bool>,
#[serde(alias = "feerange", skip_serializing_if = "crate::is_none_or_empty")]
Expand Down
1 change: 1 addition & 0 deletions contrib/msggen/msggen/gen/grpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ def generate_composite(self, prefix, field: CompositeField) -> None:
'msat_or_any?': f'c.{name}.as_ref().map(|a| a.into())',
'feerate': f'c.{name}.as_ref().unwrap().into()',
'feerate?': f'c.{name}.as_ref().map(|a| a.into())',
'outpoint?': f'c.{name}.as_ref().map(|a| a.into())',
'RoutehintList?': f'c.{name}.clone().map(|rl| rl.into())',
'short_channel_id': f'cln_rpc::primitives::ShortChannelId::from_str(&c.{name}).unwrap()',
'short_channel_id?': f'c.{name}.as_ref().map(|v| cln_rpc::primitives::ShortChannelId::from_str(&v).unwrap())',
Expand Down
496 changes: 248 additions & 248 deletions contrib/pyln-testing/pyln/testing/node_pb2.py

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion doc/lightning-close.7.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ we quickly accept the peer's proposal.

The default is "50%".

*wrong_funding_txid* can only be specified if both sides have offered
*wrong_funding* can only be specified if both sides have offered
the "shutdown_wrong_funding" feature (enabled by the
**experimental-shutdown-wrong-funding** option): it must be a
transaction id followed by a colon then the output number. Instead of
Expand Down
2 changes: 1 addition & 1 deletion doc/schemas/close.request.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"description": ""
},
"wrong_funding": {
"type": "txid",
"type": "outpoint",
kristapsk marked this conversation as resolved.
Show resolved Hide resolved
"description": ""
},
"force_lease_closed": {
Expand Down