dual-fund: Fail if you try to buy a liquidity ad w/o dualfunding on #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/warn-no-dualfund
branch
from
7b3f12e
to
e436171
Compare
|
I wonder if we couldn't just check if the Anyway, this appears to address this issue. ACK e436171 |
Fixes ElementsProject#5271 In-Collaboration-With: Base58 'n Coding Seminar Participants Changelog-Changed: `fundchannel` now errors if you try to buy a liquidity ad but dont' have `experimental-dual-fund` enabled
cdecker
force-pushed
the
nifty/warn-no-dualfund
branch
from
e436171
to
49d7e7f
Compare
|
Rebased to kick the broken CI job off the list ACK 49d7e7f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5271
In-Collaboration-With: Base58 'n Coding Seminar Participants
Changelog-Changed:
fundchannelnow errors if you try to buy a liquidity ad but dont' haveexperimental-dual-fundenabled