peer_control: Fix check_funding_details assert #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check funding_outnum validity first to avoid reading invalid outputs Changelog-Fixed: Fixed a potential issue if the number of outputs decreases in a dualopen RBF or splice.
ddustin
force-pushed
the
ddustin/check_funding_fix
branch
from
c2109b5
to
275b534
Compare
|
|
||
| if (!amount_asset_is_main(&asset)) | ||
| if (funding_outnum >= tx->wtx->num_outputs) |
There was a problem hiding this comment.
do you think that in this case can be necessary to add a log line at debug level? or this check will be pretty clear to debug if happens ?
|
ACK 275b534 Flaky tests are flaky... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check funding_outnum validity first to avoid reading invalid outputs.
Changelog-Fixed: Fixed a potential issue if the number of outputs decreases in a dualopen RBF or splice.