Commando: "Somewhere, somehow, someone's going to pay."

[rustyrussell]

This is, honestly, the greatest plugin ever written.

It allows use of the already-established Lightning network protocol to control a node, and in addition supports authorization cookies (called "runes") which are easy to craft and powerful. Runes can restrict what commands can be run, what nodes can run them, what parameters can be given, limit what time the rune is valid for, and ratelimit how often the rune can be used. You can decode them into human readable form, and add new restrictions to them.

This is a reimplementation (and streamlining) of the commando.py plugin. It is always on, but doesn't do anything until you create your first rune.

It is fully documented, too. With examples!

Credit for naming: @cdecker

[rustyrussell]

Rebased on #5735:

• Fixed schema flaw found by @SimonVrouwe
• Added typo fix from @zerofeerouting

[jb55]

this is amazing! testing now

[rustyrussell]

Merged typo fix by @jb55 and rebased on master (again!) to fix some flakes...

[rustyrussell]

Rebase on master, thanks to some prereqs being merged from @adi2011 !

[rustyrussell]

Needs rebase now that makesharesecret is in with different API. See #5430

[rustyrussell]

Rebased on #5430

[jb55]

I turned off the plugin and ran this branch and all my apps still work. amazing.

[jb55]

and it's fast 🤯

looks like guilt got confused and made me the author on 74785ce ?

[rustyrussell]

and it's fast 🤯

looks like guilt got confused and made me the author on 74785ce ?

Ah, I squashed your fix in there. I'll fix, especially since I have to rebase to fix conflicts anyway...

[rustyrussell]

Rebased on master, fixed @jb55 fix which made him author of the plugin :)

[vincenzopalazzo]

ACK 2e13b72

The following test failure looks unrelated, and also looks like untracked? cc @niftynei

=================================== FAILURES ===================================
__________________________ test_v2_open_sigs_restart ___________________________
[gw0] linux -- Python 3.7.13 /opt/hostedtoolcache/Python/3.7.13/x64/bin/python3
node_factory = <pyln.testing.utils.NodeFactory object at 0x7f5e8b394d10>
bitcoind = <pyln.testing.utils.BitcoinD object at 0x7f5e8ac14490>
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
@pytest.mark.developer("uses dev-disconnect")
@pytest.mark.openchannel('v2')
deftest_v2_open_sigs_restart(node_factory, bitcoind):
        disconnects_1 = ['-WIRE_TX_SIGNATURES']
        disconnects_2 = ['+WIRE_TX_SIGNATURES']
        l1, l2 = node_factory.get_nodes(2,
                                        opts=[{'disconnect': disconnects_1,
'may_reconnect': True},
                                              {'disconnect': disconnects_2,
'may_reconnect': True}])
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        amount = 2**24
        chan_amount = 100000
        bitcoind.rpc.sendtoaddress(l1.rpc.newaddr()['bech32'], amount / 10**8 + 0.01)
        bitcoind.generate_block(1)
# Wait for it to arrive.
        wait_for(lambda: len(l1.rpc.listfunds()['outputs']) > 0)
# Fund the channel, should appear to finish ok even though the
# peer fails
with pytest.raises(RpcError):
            l1.rpc.fundchannel(l2.info['id'], chan_amount)
        chan_id = first_channel_id(l1, l2)
        log = l1.daemon.is_in_log('{} psbt'.format(chan_id))
assert log
        psbt = re.search("psbt (.*)", log).group(1)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.daemon.wait_for_log('Peer has reconnected, state DUALOPEND_OPEN_INIT')
with pytest.raises(RpcError):
>           l1.rpc.openchannel_signed(chan_id, psbt)
E           Failed: DID NOT RAISE <class 'pyln.client.lightning.RpcError'>