feat: config additions #5136
feat: config additions #5136
Conversation
lightningd/options.c
Outdated
| @@ -1117,6 +1137,9 @@ static void register_opts(struct lightningd *ld) | |||
| opt_register_arg("--announce-addr", opt_add_announce_addr, NULL, | |||
| ld, | |||
| "Set an IP address (v4 or v6) or .onion v3 to announce, but not listen on"); | |||
| opt_register_noarg("--disable-ip-discovery", opt_set_invbool, | |||
| &ld->config.announce_discovered_ip, | |||
| "Turn off address announcement of detected public IP"); | |||
There was a problem hiding this comment.
Just a note: I usually prefer positive options, not negative, with the default being !ld->always_use_proxy.
In theory always-use-proxy could be a normal SOCKS proxy, and for all we know you've set up a reverse tunnel. But that's a really weird case (and you can just advertize an explicit IP for that).
There was a problem hiding this comment.
Hm, if I make it a positive bool option, then ip announcement can't be enabled by default, otherwise the switch would do nothing. Or do I get somthing wrong? What I could do is rename the internal code variables also to disable_ip_discovery which defaults to false and use an opt_set_bool instead of opt_set_invbool. Do you meant that?
There was a problem hiding this comment.
I renamed the internal variable also to disable_ip_discovery defaulting to false. This is now a switch, not an bool option. The switch effectively turns of ip discovery anouncements by using opt_set_bool instead of opt_set_invbool.
Can you re-check?
|
You need to add the names to the doc/schemas/listconfig.schema.json file too... |
m-schmoock
force-pushed
the
feat/config_additions
branch
from
0768ffc to
5fce184
Compare
This adds config and commandline options for htlc_min_msat, htlc_max_msat and announce_discovered_ip. The default is 0msat for htlc_min_msat, unlimited for htlc_max_msat and enabled for announce_discovered_ip. The announce_discovered_ip gets the disable commandline switch --disable-ip-discovery Changelog-added: Config options for htlc_min_msat, htlc_max_msat and announce_discovered_ip.
m-schmoock
force-pushed
the
feat/config_additions
branch
2 times, most recently
from
7a745fd to
5996ca7
Compare
doc/schemas: adds htlc min/max and ip discovery
m-schmoock
force-pushed
the
feat/config_additions
branch
from
5996ca7 to
084a717
Compare
I put this in the config, and it says But passing it on the command line is okay. |
|
That's because it's a switch and not an argument. Try without |
This adds config and commanline switches for HTLC min/max values and announcement of auto discovered IPs