Nits and fixups #5016
Merged
Nits and fixups #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't used anywhere, so we remove it.
Add missing field to first write
vincenzopalazzo
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
ack 087ca31
The CI error looks strange, and maybe it needs another run!
|
Seems the JSON-RPC schema needs to be updated: |
niftynei
force-pushed
the
nifty/acct-fixups
branch
2 times, most recently
from
fae0f32 to
dd58182
Compare
vincenzopalazzo
approved these changes
Jan 24, 2022
doc/schemas/listpeers.schema.json
Outdated
Comment on lines
238
to
241
| "funding_outnum": { | ||
| "type": "u32", | ||
| "description": "The 0-based output number of the funding transaction which opens the channel" | ||
| }, |
There was a problem hiding this comment.
Mh from CI there is a formatting problem here, maybe a make check-fmt-schemas will call jq to auto-formatting the json file
There was a problem hiding this comment.
Yep that was the issue for this test. Nice catch!
Changelog-Added: JSONRPC: `listchannels` now includes the `funding_outnum`
The money moved into an external account here.
There is no "wallet_lib_headers" variable in wallet/Makefile
niftynei
force-pushed
the
nifty/acct-fixups
branch
from
dd58182 to
86c9958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things found while working on the accountant plugin.
I have no idea how the wallet error made it past previous checks. Whoops.
The
listchannelsaddition of the funding_outnum is extremely useful for backfilling missed channel open events.