Cleanups: stabilize tests and make sqlite version checks less aggressive #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
ack 653797d
Happy to see the check on db less aggressive, thanks.
rustyrussell
requested changes
Oct 10, 2021
We were really strict with the version check, requiring an exact match. We now check that we are running at least with the version we were compiled with (distro upgrades continue to work, and repro builds are built off of an unupdated installation matching this minimum requirement), and a major version match (since major versions can and will introduce breaking changes). Changelog-Fixed: sqlite3: Relaxed the version match requirements to be at least a minimum version and a major version match
This was getting flaky whenever we had multihop routing syncs and had `DEVELOPER=0`, which uses the slow gossip propagation.
Gossmap makes use of the proto, this ensures we have it.
|
Removed the commit for the static key upgrade since it was included in #4804 |
rustyrussell
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4848