experimental-websocket-port: option to accept websocket connections on additional port. #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
feature
protocol
rustyrussell
force-pushed
the
guilt/websockets
branch
from
1006906
to
2788fb4
Compare
cdecker
reviewed
Jul 30, 2021
rustyrussell
force-pushed
the
guilt/websockets
branch
from
2788fb4
to
03c8634
Compare
rustyrussell
force-pushed
the
guilt/websockets
branch
from
03c8634
to
ea6de62
Compare
|
Trivial rebase, and added Changelog-EXPERIMENTAL line. |
rustyrussell
force-pushed
the
guilt/websockets
branch
2 times, most recently
from
c896708
to
6422261
Compare
|
Looking good, we could merge this as soon as it gets undrafted :-) |
rustyrussell
force-pushed
the
guilt/websockets
branch
from
6422261
to
3a4a277
Compare
rustyrussell
changed the title
rustyrussell
force-pushed
the
guilt/websockets
branch
3 times, most recently
from
03e3137
to
bff4a86
Compare
|
Thanks, will review and merge into v0.10.2 if we have time. |
|
ACK bff4a86 |
Signed-off-by: Rusty Russell <[email protected]>
If the port is set, we spawn it (lightning_websocketd) on any connection to that port. That means websocketd is a per-peer daemon, but it means every other daemon uses the connection normally (it's just actually talking to websocketd instead of the client directly). Signed-off-by: Rusty Russell <[email protected]>
WebSocket is a bit weird: 1. It starts like an HTTP connection, but they send special headers. 2. We reply with special headers, one of which involves SHA1 of one of theirs. 3. We are then in WebSocket mode, where each frame starts with a 2-20 byte header. We relay data in a simplistic way: if either side sends something, we read it and relay it synchronously. That avoids any gratuitous buffering. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
cdecker
force-pushed
the
guilt/websockets
branch
from
bff4a86
to
702d485
Compare
|
Rebased on top of ACK 702d485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of lightning/bolts#891
(Updated to match spec, which now says you should advertize a new address type, not a feature).
Changelog-None: experimental features are not changlogged.