Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funderupdate: add documentation, update some params #4664

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

niftynei
Copy link
Collaborator

Documentation for the funderupdate command on the funder plugin.
Realized we were missing the "leases_only" in the output; also adds
'_msat' to msat denominated outputs so they're parsed correctly by our
python bindings (also matches our naming conventions)

Changelog-EXPERIMENTAL: funder: funderupdate command to view and update params for contributing our wallet funds to v2 channel openings. Provides params for enabling option_will_fund.

@niftynei niftynei added this to the v0.10.1 milestone Jul 20, 2021
@niftynei niftynei requested a review from cdecker as a code owner July 20, 2021 17:44
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 9c1f8ad

Not the best person to ack the documentation, but for me looks good. In addition, the github actions failure seems unrelated to the last change but I think the is still a min_their_funding in the test.

With a quick research, I found the following occurrence

Documentation for the funderupdate command on the funder plugin.
Realized we were missing the "leases_only" in the output; also adds
'_msat' to msat denominated outputs so they're parsed correctly by our
python bindings (also matches our naming conventions)

Changelog-EXPERIMENTAL: funder: `funderupdate` command to view and update params for contributing our wallet funds to v2 channel openings. Provides params for enabling `option_will_fund`.
@niftynei
Copy link
Collaborator Author

Yep, missed a test case that used the key. Updated, should be through CI soon.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 64aa609

@niftynei niftynei merged commit 90c5f9a into ElementsProject:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants