dual-fund: no feestep #4648
Merged
dual-fund: no feestep #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked on merge of rustyrussell/lnprototest#16 (updates to rbf tests in protocol tests) |
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Jul 14, 2021
Depending on ElementsProject#4648 Signed-off-by: Vincenzo Palazzo <[email protected]>
niftynei
force-pushed
the
nifty/no_fee_step
branch
from
2263a7c
to
a82baae
Compare
We were getting off-by-one for the total amount that the change is for, since it rounds the fee *down*, independent of the total weight of the entire tx. We fix this by using the diff btw the fee of the total weight (w/ and w/o the change output)
niftynei
force-pushed
the
nifty/no_fee_step
branch
from
a82baae
to
8084926
Compare
vincenzopalazzo
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
ack 8084926
ERROR tests/test_db.py::test_backfill_scriptpubkeys - OSError: [Errno 39] Dir...
The github action look a like a unluck run
Using a 'feestep' is more restrictive than you'd want, instead we enforce that the next feerate must be at least 1/64th more than the last, but put no upper limit on it Includes update to lnprototest changes Contributed-By: Vincenzo Palazzo <[email protected]> Changelog-EXPERIMENTAL: Protocol: Replaces init_rbf's `fee_step` for RBF of v2 opens with `funding_feerate_perkw`, breaking change
niftynei
force-pushed
the
nifty/no_fee_step
branch
from
8084926
to
26f9692
Compare
|
ACK 26f9692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fee_stepportion of the spec was cute but not really servicable, especially given that there's no guarantee that bumping the fee by 25% will put you over the required min_relay fee bump.Instead, we just let the opener specify a new feerate, and require that it's at least 1/64th more than the last "successful" one (that means we've swapped tx_sigs for it successfully, it might still fail to broadcast).
Includes a fix for estimating the additional fee that a change output adds to the tx; we weren't considering the total weight which means it was possible to get off-by-one errors on the rounding.
This is a breaking change with prior dual-funding implementations.