invoice: allow creation of giant invoices. #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| l2.rpc.invoice(4294967295 + 1, 'inv3', '?') | ||
| # Make sure wumbo invoices warn about mpp being needed. | ||
| inv = l2.rpc.invoice(4294967295 + 1, 'inv3', '?') | ||
| assert 'warning_mpp' in inv | ||
| l2.rpc.invoice(4294967295, 'inv3', '?') |
There was a problem hiding this comment.
From Github actions
/home/runner/work/lightning/lightning/contrib/pyln-client/pyln/client/lightning.py:388>]
test_invoice failed; it passed 0 out of the required 1 times.
<class 'pyln.client.lightning.RpcError'>
RPC call failed: method: invoice, payload: {'msatoshi': 4294967295, 'label': 'inv3', 'description': '?'}, error: {'code': 900, 'message': "Duplicate label 'inv3'"}
[<TracebackEntry /home/runner/work/lightning/lightning/tests/test_invoices.py:60>, <TracebackEntry /home/runner/work/lightning/lightning/contrib/pyln-client/pyln/client/lightning.py:845>, <TracebackEntry /home/runner/work/lightning/lightning/contrib/pyln-testing/pyln/testing/utils.py:623>, <TracebackEntry /home/runner/work/lightning/lightning/contrib/pyln-client/pyln/client/lightning.py:388>]
This is a bit strange, why we don't see it in previous tests?
There was a problem hiding this comment.
Because we originally had it failing the first inv3 invoice creation, now it succeeds, so the next one fails.
vincenzopalazzo
approved these changes
Jun 17, 2021
lightning/bolts#877 talks about removing this restriction (only Electrum actually enforced it on receive), so start by allowing creation of giant invoices, though we mark them as requiring mpp. Changelog-Changed: JSON-RPC: `invoice` now allows creation of giant invoices (>= 2^32 msat) Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
allow-wumbo-invoices
branch
from
3c68a24
to
e431670
Compare
|
Yep, fixed. I obv failed to run local tests :( |
|
Restarted CI since the failure seems to be a flaky reorg test ACK e431670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightning/bolts#877 talks about
removing this restriction (only Electrum actually enforced it on
receive), so start by allowing creation of giant invoices, though
we mark them as requiring mpp.