pay: Do not attempt to filter routehints if we can't find ourselves #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI found a real bug? |
There are a couple of ways this can happen, but we shouldn't crash. Fixed ElementsProject#4488 Fixes ElementsProject#4533 Changelog-Fixed: pay: Fixed an issue when filtering routehints when we can't find ourselves in the local network view.
cdecker
force-pushed
the
fix-no-src-routehints-filter
branch
from
c06527e
to
94bd509
Compare
|
Yep, forgot to remove the second declaration of |
|
Seems my first two commits (add plugin to hooks, and add status field to |
|
I think CI failure is unrelated: have a fix... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of ways this can happen, but we shouldn't crash.
Fixed #4488
Fixes #4533