Suggested code cleanup by TODO comment #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
clenup_code
branch
from
4920e97
to
1fdcf82
Compare
vincenzopalazzo
changed the title
vincenzopalazzo
force-pushed
the
clenup_code
branch
2 times, most recently
from
9373ebb
to
8746bbe
Compare
cdecker
reviewed
May 11, 2021
vincenzopalazzo
force-pushed
the
clenup_code
branch
2 times, most recently
from
77a9e71
to
38b8bd3
Compare
vincenzopalazzo
force-pushed
the
clenup_code
branch
from
38b8bd3
to
3258e75
Compare
vincenzopalazzo
force-pushed
the
clenup_code
branch
4 times, most recently
from
cc1a7e7
to
caad17d
Compare
vincenzopalazzo
force-pushed
the
clenup_code
branch
4 times, most recently
from
8a7a1aa
to
e290fb1
Compare
niftynei
reviewed
May 25, 2021
vincenzopalazzo
force-pushed
the
clenup_code
branch
3 times, most recently
from
b86c6c0
to
48f4770
Compare
|
@niftynei Rebased and fold all the commits in only one, sorry for the missing steps. I'm thinking, to put in the .gitignore the generated files like "wallet/db_postgres_sqlgen.c", but I'm not sure if I'm missing some important steps. Let's wait for Github actions 🪑 |
vincenzopalazzo
force-pushed
the
clenup_code
branch
2 times, most recently
from
010b1f1
to
30bf4f6
Compare
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
clenup_code
branch
from
30bf4f6
to
ee98794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
(it is not ready there is a new TODO, but I use this to check better the test with Github action)introduces a code cleanup suggested by the TODO comment in the code (I don't know from who, but I guess @cdecker ).Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR #4507.
I'm not sure that this code is better than the code before, also because I'm learning C, so this PR could be a big mistake
Signed-off-by: Vincenzo Palazzo [email protected]