db: Guard access to channel_htlcs.malformed_onion with a NULL check #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a classic case for COMPAT, or even a db migration? |
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Feb 14, 2021
This ensures that after the migration in the previous commit we never insert a new htlc with a null value. Fixes: ElementsProject#4363 Reported-by: Zoltán Gálli <@gallizoltan> Changelog-Fixed: db: Fixed an access to a NULL-field in the `channel_htlcs` table and resulting warning.
|
Good point, the migration allows us not to use the |
vibhaa
pushed a commit
to spider-pcn/lightning
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix it twice: once when accessing the field, and a second time by
inserting the default value
0on insert. The latter is likely to bepreferred, but the latter former is also need to fix existing wallets.
Fixes: #4363
Reported-by: Zoltán Gálli <@gallizoltan>
Changelog-Fixed: db: Fixed an access to a NULL-field in the
channel_htlcstable and resulting warning.