pyln: extend msat floating testcases #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
force-pushed
the
pyln/fix_millisatoshi_floats
branch
from
3f114b5
to
b814575
Compare
cdecker
approved these changes
Dec 7, 2020
m-schmoock
force-pushed
the
pyln/fix_millisatoshi_floats
branch
from
b814575
to
47ee4e7
Compare
This adds two more xfail'ing testcases to show that the current way of parsing Millisatoshi decimals is not yet optimal. Changelog-None
m-schmoock
force-pushed
the
pyln/fix_millisatoshi_floats
branch
from
47ee4e7
to
2486aab
Compare
|
ACK 2486aab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was rethinking PR #4237 and discovered that we are not done yet.
This adds two more xfail'ing testcases to show that the current way of
parsing Millisatoshi decimals is not yet optimal.
Testcases:
test_round_zeroandtest_round_downfail.Changelog-None