Check whether the recipient supports keysend #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
keysend-check
branch
from
9854082 to
9dc9a51
Compare
|
Ack 9dc9a51 But you have to fix up tests which broke... |
cdecker
force-pushed
the
keysend-check
branch
2 times, most recently
from
0c9bbd4 to
1ee3c64
Compare
|
Rolled up the fixups. The remaining issue is unrelated (flaky Ready to merge ^^ |
cdecker
force-pushed
the
keysend-check
branch
from
1ee3c64 to
25936ae
Compare
We were blindly initiating the keysend payment, which could lead to confusing outcomes. This adds a very specific error message to the error returned. Changelog-Fixed: keysend: Keysend now checks whether the destination supports keysend before attempting a payment. If not a more informative error is returned.
rustyrussell
approved these changes
Dec 10, 2020
plugins/libplugin-pay.h
Outdated
|
|
||
| /* A way for a plugin to interrogate the gossip map for things | ||
| * it needs to know. */ | ||
| const struct gossmap *gossmap; |
There was a problem hiding this comment.
No, this looks like it predates get_gossmap() which returns this? That would explain why this doesn't compile, too.
Stashing it in the struct payment is really ugly, too...
rustyrussell
force-pushed
the
keysend-check
branch
from
25936ae to
ac9f7dd
Compare
|
ACK ac9f7dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't checking whether the recipient supports
keysendor not before trying to pay. This could lead to rather unhelpful 16399 errors, because the recipient simply doesn't understand what we're trying to do.This might be the cause for #3968, but I can't verify that that's the case.
Fixes #3968