Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyln-testing: require bitcoin v0.20.1 for PSBT handling, and create wallet for v0.21 #4179

Merged

Commits on Nov 9, 2020

  1. pyln-testing: require bitcoin v0.20 for PSBT handling, and create wal…

    …let for v0.21
    
    With older bitcoind, PSBTs fail:
    
    ```
        def test_utxopsbt(node_factory, bitcoind, chainparams):
    ...
    >       psbt = bitcoind.rpc.decodepsbt(funding['psbt'])
    
    tests/test_wallet.py:561:
    ...
    self = <bitcoin.rpc.RawProxy object at 0x7f4ec602e100>, service_name = 'decodepsbt'
    args = ('cHNidP8BADMCAAAAAaoMihSVXlpdBHGcJePiroqtwq/b1zu09j8IkTG4OKs7AQAAAAD9////AGYAAAAAAQDeAgAAAAABAefqB6BkZE1/AqXaf36T02a7.../7Stf971PEgvUXgvASECXPTIO6tIVxDih6tfKy6suj6WJhhjycwoaTeuso/AQ8llAAAAAQEfQEIPAAAAAAAWABQB+tkKvNZml+JZIWRyLeSpXr7hZQA=',)
    postdata = '{"version": "1.1", "method": "decodepsbt", "params": ["cHNidP8BADMCAAAAAaoMihSVXlpdBHGcJePiroqtwq/b1zu09j8IkTG4OKs7AQ...gvUXgvASECXPTIO6tIVxDih6tfKy6suj6WJhhjycwoaTeuso/AQ8llAAAAAQEfQEIPAAAAAAAWABQB+tkKvNZml+JZIWRyLeSpXr7hZQA="], "id": 1}'
    headers = {'Authorization': b'Basic cnBjdXNlcjpycGNwYXNz', 'Content-type': 'application/json', 'Host': 'localhost', 'User-Agent': 'AuthServiceProxy/0.1'}
    response = {'error': {'code': -22, 'message': 'TX decode failed PSBT is not sane.: iostream error'}, 'id': 1, 'result': None}
    ```
    
    Signed-off-by: Rusty Russell <[email protected]>
    Changelog-Changed: *** Requires bitcoind v0.20.1 or above ***
    rustyrussell authored and niftynei committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    e913f19 View commit details
    Browse the repository at this point in the history