Connection timeout #4039
Merged
Connection timeout #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
approved these changes
Sep 11, 2020
lightningd/options.c
Outdated
| @@ -694,6 +700,9 @@ static const struct config mainnet_config = { | |||
|
|
|||
| /* Allow to define the default behavior of tor services calls*/ | |||
| .use_v3_autotor = true, | |||
|
|
|||
| /* 10 minutes should be enough for anyone! */ | |||
| .connection_timeout_secs = 600, | |||
There was a problem hiding this comment.
This is very conservative ? I'd rather not start funding a channel with a peer who took 9 minutes to respond to init..
Comment on lines
+2643
to
+2645
| opts=[{'dev-timeout-secs': 1, | ||
| 'disconnect': ['0WIRE_INIT', '0WIRE_INIT']}, | ||
| {}]) |
There was a problem hiding this comment.
Interesting, i wondered why you disconnected l1 to test the timeout on l1 and started testing the other way around: this would not trigger a timeout but a connection reset error.
Why specifying two times though ?
There was a problem hiding this comment.
Wanted to test incoming timeout didn't corrupt or leak memory. But this doesn't actually do that (since the incoming fails with Connection reset as soon at it hits the dev-disconnect line.
Added some minor logging so we can make sure it actually fired.
This is simple, and we now can multifundchannel to every node on testnet (one simply hangs once we connect). Changelog-Fixed: Protocol: We now hang up if peer doesn't respond to init message after 60 seconds.
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/conn-timeout
branch
from
1872983
to
f939622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this because multifundchannel hung. Want it for rc2.