Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyln: Add safe fallback results for hooks #4031

Merged
merged 2 commits into from
Sep 10, 2020
Merged

pyln: Add safe fallback results for hooks #4031

merged 2 commits into from
Sep 10, 2020

Commits on Sep 9, 2020

  1. pytest: Add a test to reproduce ElementsProject#3748

    @cdecker
    cdecker committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    41e7e98 View commit details
    Browse the repository at this point in the history

  2. pyln: Add safe fallback results for hooks 

    Hooks do not tolerate failures at all. If we return a JSON-RPC error to a hook
call the only thing the main daemon can really do is to crash. This commit
adds a mapping of error to a safe fallback result, including a warning to the
node operator that this should be addressed in the plugin. The warning is
reported as a `**BROKEN**` message, and should therefore fail any testing done
on the plugin.

Changelog-Fixed: pyln: Fixed HTLCs hanging indefinitely if the hook function raises an exception. A safe fallback result is now returned instead.
    @cdecker
    cdecker committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    7f0db34 View commit details
    Browse the repository at this point in the history