Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ASAN when building with clang #4013

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Re-enable ASAN when building with clang #4013

merged 2 commits into from
Sep 24, 2020

Commits on Sep 22, 2020

  1. dual-openingd: msg_type should be dualopend_wire not u8 

    clang did the hard work here:

openingd/dualopend.c:958:42: error: result of comparison of constant 'WIRE_DUAL_OPEN_FAIL' (7003) with expression of type 'u8' (aka 'unsigned char') is always false
      [-Werror,-Wtautological-constant-out-of-range-compare]
        if ((msg_type = fromwire_peektype(msg)) == WIRE_DUAL_OPEN_FAIL) {
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~

Co-Authored-by: the clang compiler
Signed-off-by: Antoine Poinsot <[email protected]>
    @darosior
    darosior committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    a158458 View commit details
    Browse the repository at this point in the history

  2. configure: allow to run clang with ASAN 

    Prefer adding LSAN_OPTIONS="suppressions=$PWD/tests/sanitizer_suppressions/lsan" when CC=clang instead.

Changelog-Added: build: clang build now supports --enable-address-sanitizer .
Signed-off-by: Antoine Poinsot <[email protected]>
    @darosior
    darosior committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    ad06763 View commit details
    Browse the repository at this point in the history