fundpsbt/utxopsbt: let caller specify locktime, signpsbt: signing restrictions. #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
fundpsbt-locktime-arg
branch
from
7e4b204
to
e0ffec4
Compare
|
Is this strictly necessary? Does not the caller have the ability, to just mutate the |
Required for dual funding where the opener sets it. Changelog-Added: JSON-RPC: `fundpsbt` takes a new `locktime` parameter Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `utxopsbt` takes a new `locktime` parameter Signed-off-by: Rusty Russell <[email protected]>
…ign. This is an extra safety check for dual funding, where we only want to sign the inputs we provided! Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: JSON-RPC: `signpsbt` takes an optional `signonly` array to limit what inputs to sign.
You could, but I think this is neater. We'll eventually want a "version" flag, too. I've rebased and appended some more modifications, too. |
rustyrussell
changed the title
rustyrussell
force-pushed
the
fundpsbt-locktime-arg
branch
from
e0ffec4
to
e01da0b
Compare
niftynei
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for dual funding where the opener sets it.
Changelog-Added: JSON-RPC: fundpsbt takes a new
locktimeparameterSigned-off-by: Rusty Russell [email protected]