Important plugin #3890
Important plugin #3890
Conversation
ZmnSCPxj
force-pushed
the
important-plugin
branch
3 times, most recently
from
58c0493
to
7ea27bd
Compare
|
Fix documentation (we need to say |
There was a problem hiding this comment.
Mostly copy suggestions et al.
The API for this seems a bit clunky, especially the requirement to list both unimportant and disable (and ordered, yikes) as well as the important-plugin + plugin.
Minimal IF* states that we should do the minimal amount possible to achieve the goal, which I think would be just the addition of important-plugin. If the need for an unimportant-plugin disparate from disable arises later, it can be added.
* This is a fanciful interpretation of MINIMAL_IF
…built-in plugins.
ZmnSCPxj
force-pushed
the
important-plugin
branch
from
7ea27bd
to
cd4c510
Compare
|
Updated as per @niftynei feedback. |
ZmnSCPxj
force-pushed
the
important-plugin
branch
3 times, most recently
from
ba37732
to
d93db11
Compare
|
Looks good, but Travis is deeply unhappy... |
…lightningd also terminates. Changelog-Added: New option `--important-plugin` loads a plugin is so important that if it dies, `lightningd` will exit rather than continue. You can still `--disable-plugin` it, however, which trumps `--important-plugin` and it will not be started at all.
Changelog-Changed: plugin: Builtin plugins are now marked as important, and if they crash, will cause C-lightning to stop as well.
…velopers who want to mess around with the builtin plugins.
ZmnSCPxj
force-pushed
the
important-plugin
branch
from
d93db11
to
f69c694
Compare
|
Fixed the valgrind bug that was making travis unhappy (why did travis keep rerunning the test tho???) and added |
Closes #3213
Builtin plugins are automatically made important.