lightningd/chaintopology.h: Remove unused txnums field from struct block.
#3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3858
Code related to this field was last updated in 2017. It is initialized to a pointless 0-length array, in code that was last touched in 2016. No other code reads from it, writes to it, or even does something like extend the array.
Removing since I want to change the interface between
bcliandlightningd, which implies that thestruct blockwould actually be reported in JSON form bybclitolightningd, and sincetxnumsis unused anyway, we can remove it and simplify what we will eventually need frombcli.