Config: revive --commit-fee #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
commit_fee_config
branch
from
587114e to
072c674
Compare
|
Should we add a pyln test for this flag so that it doesn't get lost again? |
We did not take the value of --commit-fee into account : this removes the unused option from lightningd and instead registers it in bcli, where we set the actual feerate of commitment transactions. This also corrects the documentation. Changelog-Fixed: config: we now take the --commit-fee parameter into account. Signed-off-by: Antoine Poinsot <[email protected]>
Correct some comments wrt estimatefees, add a constructor for bitcoind Signed-off-by: Antoine Poinsot <[email protected]>
Signed-off-by: Antoine Poinsot <[email protected]>
darosior
force-pushed
the
commit_fee_config
branch
from
072c674 to
13f14ad
Compare
|
Yes, I added a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been ignored for quite some time apparently (a quick
git log -Stells me we don't use it since88bb38f63b46eeac6ea3f3a29b71dd9aca6cacd0, but not sure though) and the doc was wrong.