Fix: remove option_large_channels from channel_announcements. #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/channel-announcement-bug
branch
from
bfa2342
to
f02648c
Compare
rustyrussell
force-pushed
the
guilt/channel-announcement-bug
branch
2 times, most recently
from
510e674
to
e639663
Compare
Signed-off-by: Rusty Russell <[email protected]>
There are various places where our tests failed with --enable-expimental-features. And our plugin test overlapped an existing feature. We make our expected_feature functions more generic, and use them everywhere. Signed-off-by: Rusty Russell <[email protected]>
…ncement features for wumbo channels. Signed-off-by: Rusty Russell <[email protected]>
And neaten current feature mangling code now we have a wumbo flag for expected_peer_features(). Signed-off-by: Rusty Russell <[email protected]>
…ment. Spec is wrong (it says it should be compulsory), and Eclair doesn't set it at all, leading to an error when they send their announcement_signatures. Fixes: ElementsProject#3703 Signed-off-by: Rusty Russell <[email protected]> Changelog-changed: large-channels: negotiate successfully with Eclair nodes.
rustyrussell
force-pushed
the
guilt/channel-announcement-bug
branch
from
e639663
to
194a320
Compare
niftynei
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that we didn't do this the way the spec said, nor the way Eclair does. This change is a compatibility break with existing 0.8.2 nodes, so I suggest we backport the minimal change (part of the final commit) and release 0.8.2.1.
There is no good alternative: once we find they've signed a different thing, we've already sent our signatures to them.