Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Alpine #3660

Merged
merged 1 commit into from
May 1, 2020
Merged

Add documentation for Alpine #3660

merged 1 commit into from
May 1, 2020

Conversation

dr-bonez
Copy link
Contributor

No description provided.

niftynei
niftynei reviewed Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a nit, can you collapse all three of these commits into a single one, since the last 2 are really fixes to mistakes made in the first one (extra space, incorrect ordering)

@niftynei
Copy link
Collaborator

niftynei commented Apr 23, 2020 •
edited
Loading

Also, you should include a 'changelog' entry in your commit message. see STYLE.md. You can see an example of this in action here 68a2351

@dr-bonez
docs: Add documentation for Alpine to INSTALL.md
47e036d 
Changelog-Added: docs: Install documentation now has information about building for Alpine linux
@cdecker
Copy link
Member

cdecker commented Apr 27, 2020

ACK 47e036d

@niftynei niftynei merged commit c485cf7 into ElementsProject:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niftynei niftynei niftynei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dr-bonez @niftynei @cdecker