pyln-client: send proper JSONRPC2 errors on failed call #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'd only argue that As discussed in #3638, the full traceback is left in the logs anyway, so it may just create nicer returns. |
|
Agree, will amend
-------- Original Message --------
…On Apr 10, 2020, 09:18, Sergi Delgado Segura wrote:
LGTM.
I'd only argue that str may be nicer than repr for the cmd return, since you may want to avoid debugging info on the cmd.
As discussed in [#3638](#3638), the full traceback is left in the logs anyway, so it may just create nicer returns.
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#3640 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FYJ7CP6VQUQEJI25LDRL3B57ANCNFSM4MFCQ2JA).
|
Changelog-Added: pyln now sends proper error on bad calls to plugin methods Co-Authored-By: Sergi Delgado Segura <[email protected]>
darosior
force-pushed
the
pyln_nice_error
branch
from
6d547ef
to
ed86321
Compare
rustyrussell
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3638
Added @sr-gi as a co author as he did all the search and found the cause.