Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly cleanups #3636

Merged
merged 5 commits into from
Apr 10, 2020
Merged

Weekly cleanups #3636

merged 5 commits into from
Apr 10, 2020

Commits on Apr 9, 2020

  1. pyln: Allow non-empty directory when creating node in node_factory

    So far we've always cleared the node directory when provisioning the node, but
    while testing some plugins we noticed that pre-generating some files in that
    directory is useful. This just adds yet another flag to `get_node` that
    disables deleting any existing node directory.
    cdecker committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    e0f981e View commit details
    Browse the repository at this point in the history
  2. fundchannel: Remove the now disabled deprecated satoshi param

    While we removed the `satoshi` param in ElementsProject#3603 it appears that the
    `fundchannel` plugin was still passing it to the `fundchannel_start`
    call. This fixes up the help text. Notice that technically the help text
    changes the param name, but since it was internally always called `amount`
    this change doesn't break the API, the help was just wrong.
    cdecker committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ccf9781 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. invoice: Parse amounts without a multiplier as BTC not msats

    The spec states that invoices with an amount, but lacking a multiplier, should
    be interpreted as integer Bitcoin amounts:
    
       `amount`: optional number in that currency, followed by an optional
       `multiplier` letter. The unit encoded here is the 'social' convention of a
       payment unit -- in the case of Bitcoin the unit is 'bitcoin' NOT satoshis.
    
    Suggested-by: Stefano Pellegrini <@St333p>
    Signed-off-by: Christian Decker <@cdecker>
    Changelog-Fixed: invoice: The invoice parser assumed that an amount without a multiplier was denominated in msatoshi instead of bitcoins.
    cdecker committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    d249e1a View commit details
    Browse the repository at this point in the history
  2. doc: Give an example of the supported DSN formats

    I was told that DSNs are not trivial to format, so this adds an example to
    help setup the postgres wallet backend.
    cdecker committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    17686ae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96e7a22 View commit details
    Browse the repository at this point in the history