Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump htlc resolution transactions feerate #3592

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

darosior
Copy link
Collaborator

This builds upon #3570 to, now that we have a specific feerate for them, bump the feerate estimation target for HTLC resolution and penalty transactions.

@darosior darosior requested a review from cdecker as a code owner March 16, 2020 00:05
@darosior darosior changed the title Bump htlc fees Bump htlc resolution transactions feerate Mar 23, 2020
@darosior
Copy link
Collaborator Author

Rebased after #3570 was merged.

Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack b7c0859

A CONSERVATIVE/3 target for them.

Some noisy changes to the tests as we had to update the estimatesmartfee
mock.

Changelog-Changed: We now use a higher feerate for resolving onchain HTLCs and for penalty transactions
@darosior
Copy link
Collaborator Author

darosior commented Apr 1, 2020

Dummy commit to force Travis to re-test.

Thanks this uncovered a fix which I thought having comitted but which was not part of the commit history anymore.
How comes the tests passed before ?..

@niftynei
Copy link
Collaborator

niftynei commented Apr 2, 2020

ACK 4723860

@niftynei niftynei merged commit 7c0af81 into ElementsProject:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants