lightning-rf #740 set feespike factor to 2 #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
force-pushed
the
fix/rfc740_feespike_factor
branch
3 times, most recently
from
0b47e45
to
78335ef
Compare
|
Surprise, we have hardcoded values in tests... I wanted to remove them ever since I got started with the elements support, since they can break way too easily. |
m-schmoock
force-pushed
the
fix/rfc740_feespike_factor
branch
2 times, most recently
from
ee60bd1
to
3effa3c
Compare
cdecker
reviewed
Mar 16, 2020
m-schmoock
force-pushed
the
fix/rfc740_feespike_factor
branch
2 times, most recently
from
e1efcef
to
2c7f8b4
Compare
Changelog-Fixed: Use lightning-rfc ElementsProject#740 feespike margin factor of 2
m-schmoock
force-pushed
the
fix/rfc740_feespike_factor
branch
from
2c7f8b4
to
9f0064c
Compare
cdecker
approved these changes
Mar 19, 2020
| * non-funder can't add any non-dust HTLCs (since the funder would | ||
| * have to pay the additional fee, but it can't afford to). This | ||
| * leads to the channel starving at the feast! This was reported by | ||
| * ACINQ's @t-bast | ||
| * (https://github.com/lightningnetwork/lightning-rfc/issues/728) and | ||
| * demonstrated with c-lightning by @m-schmook | ||
| * demonstrated with c-lightning by @m-schmoock |
There was a problem hiding this comment.
Sorry about mistyping your nickname btw 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our channel lockup drain mitigation 86c28b2 compatible with the upcoming changes of the lightning/bolts#740 wich will set this value to a factor of
2.