quick fix: a blank plugin option should be true, not false #3586
Conversation
|
Yes, as @darosior notes, pretty sure this doesn't work, since --foo will not get a callback with opt_register_arg. We'd almost need a new type to mean a simple flag argument, say We deliberately don't allow optional arguments, since they're ambigious (is |
a few things. one is that `is_in_log` returns a result rather than enforcing a condition. so these lines all need asserts two is that with the 'allow_deprecated_apis' option on, the python json parser overwrites the now typed input with the later-added string version, so the only option value present in the option key-value set is the last, string one. the check for this has been updated to only verify that the string version is included (i manually verified that both are printed to the JSON message)
Updates the plugin docs to include more detailed info about how options work. Changelog-Added: Plugins: 'flag'-type option now available.
bools must be set!
niftynei
force-pushed
the
nifty/plugin-blank-true
branch
from
f66f1a8 to
d0aa618
Compare
Hm so the tests seem to pass, but I'm not sure that the command line arguments will work the same as the python mediated options? I removed it entirely, I think it's fine to force specification.
This seemed like a fun thing to add, so I went ahead and added this as a type. |
Fix a syntactic mistake i made in #3582
Also fix the option interop test so that it actually verifies the log messages.