pyln: actually specify jsonrpc in requests #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZmnSCPxj
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
ACK a473ffc
Required by JSON-RPC 2.0 spec: https://www.jsonrpc.org/specification#request_object
As per the spec (https://www.jsonrpc.org/specification#request_object) ``` A rpc call is represented by sending a Request object to a Server. The Request object has the following members: jsonrpc A String specifying the version of the JSON-RPC protocol. MUST be exactly "2.0". ``` Changelog-fixed: pyln now includes the "jsonrpc" field to jsonrpc2 requests
|
Amended the commit, forgot the Changelog.. |
|
Doh, my fault 🤦♂️ ACK 5b65174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not specifying the
jsonrpcfield in JSONRPC request produced by pyln. Uncovered this while refactoring libplugin, it made plugins crash (during functional tests, but not by-hand tests!) if we check for its presence.