channeld: don't send multiple update_fee until previous settled. #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our feerate logic is overly simplistic (ha!) and we seem to get confused on back-to-back feerate updates. Fixing it seems to require much more complex feerate logic which I am deeply reluctant to implement, as it's terribly fragile and will be discarded eventually once we have simplified commitments. Fixes: ElementsProject#2661 Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Occasional 'Bad commit_sig signature' channel failures with fee updates (ElementsProject#2661)
rustyrussell
force-pushed
the
fee-mess
branch
from
bd809b0 to
5b428ab
Compare
|
This doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our feerate logic is overly simplistic (ha!) and we seem to get confused
on back-to-back feerate updates. Fixing it seems to require much more
complex feerate logic which I am deeply reluctant to implement, as it's
terribly fragile and will be discarded eventually once we have
simplified commitments.
Fixes: #2661
Signed-off-by: Rusty Russell [email protected]
Changelog-Fixed: Occasional 'Bad commit_sig signature' channel failures with fee updates (#2661)