Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins/fundchannel: try to connect to peer before funding #3307

Closed
wants to merge 1 commit into from
Closed

plugins/fundchannel: try to connect to peer before funding #3307

wants to merge 1 commit into from

Conversation

darosior
Copy link
Contributor

@darosior darosior commented Dec 1, 2019

Just ya callback before fundchannel_start :-)

niftynei
niftynei reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does connect not require the IP address of a peer?

plugins/fundchannel.c Outdated Show resolved Hide resolved
plugins/fundchannel.c Show resolved Hide resolved
@darosior darosior force-pushed the fundchannel_connect branch from 042b7ed to 03eb810 Compare December 2, 2019 20:29
@darosior
plugins/fundchannel: try to connect to peer before funding
5bc57b9 
Changelog-Added: RPC: The 'fundchannel' command now tries to connect to the peer before funding the channel, no need to 'connect' before 'fundchannel' anymore !
@darosior darosior force-pushed the fundchannel_connect branch from 03eb810 to 5bc57b9 Compare December 3, 2019 13:46
@niftynei niftynei mentioned this pull request Dec 4, 2019
Merged
niftynei
niftynei suggested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@niftynei niftynei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #3314.

the connect should be the first command we call to lightningd, before we do the funding amount check with the txprepare reservation. apologies, i should have realized this earlier. 🙃

@darosior
Copy link
Contributor Author

darosior commented Dec 4, 2019

Nevermind I should have spent more time reading the code around the fixme 😬

@darosior darosior closed this Dec 4, 2019
@darosior darosior deleted the fundchannel_connect branch December 5, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niftynei niftynei niftynei requested changes

Assignees

@niftynei niftynei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darosior @niftynei